[GLUTEN-10933][VL]fix: Fix the CudfVector childreSize is not correct#11326
Merged
jinchengchenghh merged 1 commit intoapache:mainfrom Jan 6, 2026
Merged
[GLUTEN-10933][VL]fix: Fix the CudfVector childreSize is not correct#11326jinchengchenghh merged 1 commit intoapache:mainfrom
jinchengchenghh merged 1 commit intoapache:mainfrom
Conversation
zhztheplayer
reviewed
Jan 5, 2026
Comment on lines
+32
to
+37
| #ifdef GLUTEN_ENABLE_GPU | ||
| // The batch may be CudfVector, it's childrenSize is not correct, many tests failed if correcting the value | ||
| // https://github.com/facebookincubator/velox/pull/15629#discussion_r2581655771 | ||
| VeloxColumnarBatch(facebook::velox::RowVectorPtr rowVector, int32_t numColumns) | ||
| : ColumnarBatch(numColumns, rowVector->size()), rowVector_(rowVector) {} | ||
| #endif |
Member
There was a problem hiding this comment.
Compared to adding a new ctor, what if we just change the old ctor to call rowVector->rowType()->size()?
By the way. Why childrenSize() is inaccurate for cuDF row vector?
Contributor
Author
There was a problem hiding this comment.
Because the childrenSize() always returns 0, RowVector contains flatVector, but CudfVector contains cudf::table(contains cudf::column)
Contributor
Author
There was a problem hiding this comment.
As this discussion https://github.com/facebookincubator/velox/pull/15629/files#r2572687025
zhztheplayer
approved these changes
Jan 6, 2026
QCLyu
pushed a commit
to QCLyu/incubator-gluten
that referenced
this pull request
Jan 8, 2026
QCLyu
pushed a commit
to QCLyu/incubator-gluten
that referenced
this pull request
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After this PR facebookincubator/velox#15629, the CudfVector childrenSize is not correct, if correct it, will cause many unit tests fail as this discussion https://github.com/facebookincubator/velox/pull/15629/files#r2572687025, use a work around in Gluten to fix it.
Related issue: #10933